Replace Optional[T] and Union[T, None] with T | None#495
Open
yangdanny97 wants to merge 7 commits intoInstagram:mainfrom
Open
Replace Optional[T] and Union[T, None] with T | None#495yangdanny97 wants to merge 7 commits intoInstagram:mainfrom
Optional[T] and Union[T, None] with T | None#495yangdanny97 wants to merge 7 commits intoInstagram:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
bowiechen
reviewed
Nov 4, 2025
bowiechen
reviewed
Nov 4, 2025
bowiechen
requested changes
Nov 4, 2025
Contributor
bowiechen
left a comment
bowiechen
left a comment
There was a problem hiding this comment.
looks good! thank you for working on this.
please fix some nits and we can merge this.
Co-authored-by: Bowie Chen <543091+bowiechen@users.noreply.github.com>
Co-authored-by: Bowie Chen <543091+bowiechen@users.noreply.github.com>
bowiechen
requested changes
Nov 19, 2025
Comment on lines
76
to
+84
| [tool.black] | ||
| target-version = ["py38"] | ||
|
|
||
| [tool.fixit] | ||
| enable = ["fixit.rules"] | ||
| python-version = "3.8" | ||
| [tool.black] | ||
| target-version = ["py310"] | ||
|
|
Contributor
There was a problem hiding this comment.
you should merge these into the existing config dicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pipe syntax for unions introduced in PEP604 is more concise than
Optional, but it only works in Python 3.10+This PR updates the rule replacing
Union[T | None]withOptional[T]to replace both withT | None.Test Plan
make